-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand metalworking and other older proficiencies #44446
Conversation
Add two stages of knapping
You might also want to make repair require these new proficiencies. I have made an issue with my thoughts on repair and mending, which may be applicable. #44480 |
That will be outside this PR but yes, repair should definitely use proficiencies as well. I am open to someone making a PR like that... |
also adds a different stone axe recipe for the grind version
update professions
Add a few missed proficiencies
so... many... recipes.
Didn't remove screwdriver recipe after all, even though it's lame.
I will leave this up for review for a day or so, and then if no comments, will merge it myself as this is a big project and other things are depending on this. |
I'm not sure about making things like metalworking impossible to learn on your own: back in the day, books weren't exactly common, and many blacksmiths were probably illiterate. Though they may have learned through a master-apprentice relationship. So maybe learning through trial-and-error is slow, but much faster with an NPC giving you lessons. And I'm assuming reading a book isn't enough to develop the intuition and muscle memory required for certain tasks. |
Summary
SUMMARY: Content "Expand metalworking and other older proficiencies"
Purpose of change
Continuing to add proficiencies. Blacksmithing and knapping are the OG demo proficiencies, and need to be brought to speed to match the rest of the proficiencies that have been added.
Describe the solution
Describe alternatives you've considered
As often happens, i wound up with too much going on in this PR, because on a deep read of recipes so much stuff comes up. in the future I think I'm going to try to focus on getting a single recipe file correct rather than working on a single category of proficiencies.
Testing
Additional context