Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand metalworking and other older proficiencies #44446

Merged
merged 15 commits into from
Oct 2, 2020

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Sep 27, 2020

Summary

SUMMARY: Content "Expand metalworking and other older proficiencies"

Purpose of change

Continuing to add proficiencies. Blacksmithing and knapping are the OG demo proficiencies, and need to be brought to speed to match the rest of the proficiencies that have been added.

Describe the solution

  • Adds a metalworking proficiency that is easy to learn, and prerequisite for blacksmithing and most other basic metal shaping proficiencies. When it's possible to learn proficiencies from books and select them at the start, we should consider making this one impossible to learn by trial-and-error. For now, given how critically important it is for many gameplay options, this should wait for those systems.
  • Adds a second knapping proficiency, and makes the first one a "principles of knapping" version that is hard to figure out. The second represents speed from experience.
  • Adds a toolsmithing proficiency that, loosely, is for "things that should be durable for reuse".
  • Adds a basic and advanced welding proficiency and implements them in recipe_other and parts.json
  • Adds a plumbing proficiency. It's barely used currently but I had to do something about the water faucet recipe.
  • Audits a few autolearn and time to craft details as well as some activity levels that were a bit high.

Describe alternatives you've considered

As often happens, i wound up with too much going on in this PR, because on a deep read of recipes so much stuff comes up. in the future I think I'm going to try to focus on getting a single recipe file correct rather than working on a single category of proficiencies.

Testing

Additional context

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mechanics: Effects / Skills / Stats Effects / Skills / Stats labels Sep 27, 2020
@meelock
Copy link
Contributor

meelock commented Sep 28, 2020

You might also want to make repair require these new proficiencies. I have made an issue with my thoughts on repair and mending, which may be applicable. #44480

@I-am-Erk
Copy link
Member Author

That will be outside this PR but yes, repair should definitely use proficiencies as well. I am open to someone making a PR like that...

@I-am-Erk I-am-Erk marked this pull request as ready for review October 1, 2020 17:45
@I-am-Erk
Copy link
Member Author

I-am-Erk commented Oct 1, 2020

I will leave this up for review for a day or so, and then if no comments, will merge it myself as this is a big project and other things are depending on this.

@ZhilkinSerg ZhilkinSerg merged commit e208a89 into CleverRaven:master Oct 2, 2020
@I-am-Erk I-am-Erk deleted the proficiency-7 branch October 2, 2020 17:48
@zachary-kaelan
Copy link
Contributor

I'm not sure about making things like metalworking impossible to learn on your own: back in the day, books weren't exactly common, and many blacksmiths were probably illiterate. Though they may have learned through a master-apprentice relationship. So maybe learning through trial-and-error is slow, but much faster with an NPC giving you lessons. And I'm assuming reading a book isn't enough to develop the intuition and muscle memory required for certain tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants