Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface: Newcharacter - show proficiencies and other changes (UPDATED) #44532

Merged
merged 7 commits into from
Oct 4, 2020

Conversation

Pupsi-Mupsi
Copy link
Contributor

@Pupsi-Mupsi Pupsi-Mupsi commented Sep 30, 2020

Summary

SUMMARY: Interface "Newcharacter - Show proficiencies"

Purpose of change

Continuing with what was done in #44297 and #44465.

Changelog:

  • PROFESSION TAB: Re-added all empty values (+ previously missing like addictions)
  • DESCRIPTION TAB: Show character proficiencies
  • DESCRIPTION TAB: Re-added pick nothing but a random name
  • DESCRIPTION TAB: Always show starting vehicle and starting addictions even if empty

Screenshot(s)

PROFESSION TAB:

grafik

DESCRIPTION TAB:

grafik

@Pupsi-Mupsi Pupsi-Mupsi changed the title Interface: Newcharacter - Declutter empty profession items groups Interface: Newcharacter - Declutter empty profession item groups Oct 1, 2020
@Pupsi-Mupsi Pupsi-Mupsi changed the title Interface: Newcharacter - Declutter empty profession item groups Interface: Newcharacter - Declutter and show proficiencies Oct 1, 2020
@Night-Pryanik
Copy link
Contributor

I'm not sure if hiding empty item groups is a good idea. It's a loss of information IMO. Players could be confused: "why there's nothing said about wielded or worn items? That's because characters don't have wielded/worn items or is it a bug?"

@Pupsi-Mupsi
Copy link
Contributor Author

Pupsi-Mupsi commented Oct 1, 2020

Thanks. I see your point.

Do you feel the same way about 'profession skills', 'traits', 'pets' and the like or is it just 'profession items'?

Which version do you prefer?

Before - Profession TAB:

grafik

After #44465 - Profession TAB:

grafik

This is how it would look like after this PR:

grafik

@Night-Pryanik
Copy link
Contributor

Honestly I personally don't consider all these "foo: none" as a clutter. As I said, information about nothing being wielded/worn or zero proficiencies is still information, and important too, so removing it I will consider as a regression. Can't say for others though.

@Pupsi-Mupsi
Copy link
Contributor Author

Pupsi-Mupsi commented Oct 1, 2020

I respect your opinion. I myself think that this specific information (none) is somewhat implicit and I would consider it more valuable for new players to just see what is given by a chosen profession. (Addictions and spells were already hidden.)
As a side effect, players have to scroll less often and can grasp the essential information more quickly. CDDA can quickly become overwhelming due to its richness.

I was hoping to help with that, but I am willing to revert everything if there are enough votes for it.

By the way - all "NONE" information is still given on the "description tab". I know I still need to include items, pets, and spells, but I will eventually.

grafik

@nexusmrsep
Copy link
Contributor

I second @Night-Pryanik opinion. Character sheet boxes should be as constant as possible, much like a DnD sheets, where you have "boxes" that are either filled or not, depending of choices, but the "box" is present in every case, so that the fact that there is an option that would "fill the box" is transparent in every case. So not only "what you see is what you get" but "... also what you don't get". Although for "wielded" it would not have impact, but with "proficiencies" for example it's quite important, and having information in plain sight that your character will not start with any is significant.

@Pupsi-Mupsi
Copy link
Contributor Author

Would you like to see the NONE-info in the profession-tab or in the description-tab or in both? And should the previously to my PRs hidden information about addictions and spells also always output none if the player does not get any?

"Although for "wielded" it would not have impact, but with "proficiencies" for example it's quite important, and having information in plain sight that your character will not start with any is significant."

Isn't it also obvious that you don't have or get something if it doesn't appear in the list?

I personally agree with the character sheet concept. In game this is mostly represented in the @-menu. During the character generation I would prefer to see the NONE-info in the description-tab. where all other information is finally summarized I would keep the profession tab cleaner.

What about the rest of the changes (#44532, #44515, #44465, #44297 ), should they go away or can they stay?

@Pupsi-Mupsi Pupsi-Mupsi marked this pull request as draft October 2, 2020 19:18
@Pupsi-Mupsi Pupsi-Mupsi changed the title Interface: Newcharacter - Declutter and show proficiencies Interface: Newcharacter - show proficiencies and other changes (UPDATED) Oct 2, 2020
@Pupsi-Mupsi Pupsi-Mupsi marked this pull request as ready for review October 2, 2020 23:38
@kevingranade kevingranade merged commit 6c55b9d into CleverRaven:master Oct 4, 2020
@Pupsi-Mupsi Pupsi-Mupsi deleted the PM-new-char-declutter branch October 4, 2020 11:31
@anothersimulacrum anothersimulacrum added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants