Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newcharacter.cpp #44465

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Conversation

Pupsi-Mupsi
Copy link
Contributor

@Pupsi-Mupsi Pupsi-Mupsi commented Sep 27, 2020

Summary

SUMMARY: Interface "More newcharacter menu changes"

Purpose of change

Reopend messed up #44403.

This is just an idea for UI consistency as suggested in #12112.
Continuing with what was done in #44297.

Changelog:

  • POINTS TAB: Add helptext - might help new players
  • DESCRIPTION TAB: Implement "Starting Location" navigation via arrowkeys and edit via Popup-UI.
  • DESCRIPTION TAB: Change navigation (now UP/DOWN) and edit (now LEFT/RIGHT) action-arrowkeys to match all other newcharacter menu TABs. Change helptext accordingly.
  • DESCRIPTION TAB: New helptext and helptext-position for randomization.
  • DESCRIPTION TAB: Hide "starting vehicle" if empty
  • DESCRIPTION TAB: Show "starting addictions" if not empty
  • DESCRIPTION TAB: Change value-position, nlines and alignment
  • DESCRIPTION TAB: Show character bionics
  • PROFESSION TAB: Declutter - Don't show "empty headlines" and add a linebreak after gender helptext
  • STAT TAB: Change helptext wording and position to match all other tabs
  • STAT TAB: Change highlight color to match all other tabs
  • STAT TAB: Change stat-explaining-text color (old white - new green) to match all other tabs
  • ALL: Replace h_light_gray with new COL_SELECT
  • Various minor changes

Hope you like it.

Screenshot(s)

Before - Points TAB:

grafik

After - Points TAB:

grafik

Before - Profession TAB:

grafik

After - Profession TAB:

grafik

Before - Stat TAB

grafik

After - Stat TAB:

grafik

Before - Description TAB:

Random Character:

grafik

After - Description TAB:

Random Character:
grafik

Long Name + Vehicle:
grafik

Addiction:
grafik

Starting location via arrowkeys:
grafik

@anothersimulacrum anothersimulacrum added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Sep 27, 2020
@Rivet-the-Zombie Rivet-the-Zombie merged commit 9c1c464 into CleverRaven:master Sep 29, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Sep 29, 2020
Merge pull request CleverRaven#44465 from Pupsi-Mupsi/PM-update-nc
@Pupsi-Mupsi Pupsi-Mupsi deleted the PM-update-nc branch September 29, 2020 15:54
w_vehicle = catacurses::newwin( 2, 60, point( 80, 6 ) );
w_name = catacurses::newwin( 2, 42, point( 2, 5 ) );
w_gender = catacurses::newwin( 1, 42, point( 2, 7 ) );
w_location = catacurses::newwin( 1, TERMX - 92, point( 90, 5 ) );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimum supported terminal width is 80, thus subtracting 92 when terminal size is less than that could lead to negative number window width and crash (see #45312).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants