Use cata::optional for mutation value calculations #42932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Use cata::optional for mutation value calculations"
Purpose of change
When looking into #42853 I found that all mutations will always have all values despite them having nothing to do with them. They will also all need to be initialized to different values (0 or 1) depending on how they're intended to be used. Using optional values streamlines the initialization and makes sure only mutations with explicitly stated values will get accounted for in calculations.
Describe the solution
Change types from float to cata::optional and initialize with cata::nullopt.
Describe alternatives you've considered
Leaving as is and hoping there won't be another issue like that.
Testing
Loaded a game with a character with some traits I changed and tested if they still work.
Additional context
There are still a bunch of normal values in mutation.h because I only changed the ones used in the
calc_mutation_value
,calc_mutation_value_additive
andcalc_mutation_value_multiplicative
methods.