Scout trait not working properly

[ConnorMartin]

Even with the scout trait, my character's map vision is still 5 tiles.

Steps To Reproduce

Create a character with the scout trait
Walk around for a little while on a field
Observe the 5-tile map vision (should be 10 with scout)

Expected behavior

Scout states that it improves map vision range, so the trait should do that.

Screenshots

Versions and configuration

• OS: Windows
  • OS Version: 10.0 1903
• Game Version: 0.E-4942-gc8ac471 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Alternative Map Key [alt_map_key],
  Aftershock [aftershock]
  ]

Additional context

[wapcaplet]

@ConnorMartin Did you happen to also have the "Self-Aware" trait? I can confirm this issue, but only when I also have "Self-Aware".

The counterpart of the "Scout" trait that should reduce overmap sight range ("Topographagnosia") also has no apparent effect.

With "Scout" and "Self-Aware", overmap vision is 5 overmap tiles:

With "Topographagnosia" and "Self-Aware", overmap vision is still 5 overmap tiles:

However, without the "Self-Aware" trait, I am getting a distinct increase (~7 tiles) with "Scout", and a significant decrease (~2-3 tiles) with "Topographagnosia":

I don't know if this is intended behavior, but it's pretty strange.

Edit I have figured out how to fix this, and will submit a PR shortly.

• OS: Linux
  • OS Version: Distributor ID: Pop; Description: Pop!_OS 20.04 LTS; Release: 20.04; Codename: focal;
• Game Version: 0.E-5007-g80e32f911b [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food]
  ]

[wapcaplet]

Worth repeating here from comments on #42923 - the "Self-Aware" trait was a red herring; it turns out the "Scout" visibility range was nullified by having any other trait; in other words, "Scout" only worked if it was the only trait you had. Problems like this may be mitigated in the future by this change to mutation/trait modifiers: #42932