Query before dropping liquid #42411
Merged
Query before dropping liquid #42411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Query before dropping liquid"
Purpose of change
With the new nested container system it's now possible to select content to drop directly. However it's easy to mistakenly drop liquid content when you really want to drop the container. This PR adds a query if any selected item is liquid before dropping.
Also changed the message when you try to pick up a liquid and added an advice on how to handle spilt liquid to it.
Describe alternatives you've considered
Let my carelessness get the better of me.
Testing
Spawn liquid with container, try dropping the contained liquid, query shows up.