Include container when dumping by category or single content container

[nhayes-me]

Is your feature request related to a problem? Please describe.

My one confusion/frustration with the new inventory overhaul has been the showing of items that are in containers. The most common use-case being canned foods or medicines. Effectively the item shows up twice in the inventory screen. Beans will show up under food, then "medium tin of beans" shows up under containers. This causes problems in cases where one wants to dump all food, but if you dump by category you will empty the contents of the containers, and not the containers themselves.

Describe the solution you'd like

When a container has only one item, rather than show the container and contents separately in categories, show it once under the category of the contents. "Bottle of asprin" shows up under drugs, "Can of beans" only shows up under food.

Describe alternatives you've considered

One other alternative to consider would be that when someone tries to dump an item, it drops the container as well. This would only occur if:

• The item is the only contents in a container
• The container is not worn
• the contents of a container could be spilled

Additional context

Add any other context (such as mock-ups, proof of concepts or screenshots) about the feature request here.

[KorGgenT]

the item shows up twice in the inventory screen.

but... it doesn't. you have the can, and you have the beans. the can says it has the beans in it, so you know which can it is. how would you expect to be able to use multidrop to empty multiple containers from your inventory?

[meladath]

Honestly I feel a better solution would just be to have a warning that something you are dropping is a liquid and can get dirty. Thats the biggest problem I have with "accidentally" dropping multiple items with nested containers.

[KorGgenT]

i think the best way to do it it is deselect child items when a parent item is selected for drop. it's supposed to already do this, but there's some part of the logic that's messed up. an extra pop-up is annoying and should be avoided unless absolutely necessary, because it adds an extra button press every time you want to do it.

[kevingranade]

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/warning-youre-about-to-dump-out-all-of-your-water-by-mistake/23990/2

[wapcaplet]

the item shows up twice in the inventory screen.

but... it doesn't. you have the can, and you have the beans. the can says it has the beans in it

Sure it does - it appears once for each level of containment. So if I have a backpack with a fanny pack containing a can of beans, you'll see "beans (fresh)" four times:

The confusion here I think may stem from the fact that the order in which you select items for muti-dropping affects what happens. Above, you see I have a medium tin can of beans. Going to the multi-drop menu D, if I select (1) the can, then (2) the beans, the beans are dropped to the ground, still in the can:

However, if I select (1) the beans, then (2) the can, the beans are dumped separately on the ground:

Had this been a liquid, it would now be dirty:

The act of uncapping (possibly several) sealed liquid containers and pouring their contents onto the ground certainly seems like a significant enough activity to warrant an extra keypress or two confirming it - it is definitely not the kind of thing anyone could do by accident.

[wapcaplet]

Related to #41126 (accidentally dumping out liquids when dropping).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[wapcaplet]

This issue is mitigated by #42411 (query before dropping liquids from their container), which fixed the isssue I mentioned above. The matter of containers and contents appearing separately is covered by #40310. And the idea of putting containers in the category of their contents is now partly addressed (in the context of zone sorting and advanced inventory) by #41820. So this issue is largely fixed now. Closing.