Fix zone sorting and category display in advanced inventory UI. #41820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
<Bugfix>
|
Note: category is now dynamic and depends on container contents. If category values are cached in Zone manager or advanced inventory UI AND are not updated when item is updated, then it may lead to outdated category being displayed. So far I have not seen this happened. But maybe someone who knows the code of Zone manager or advanced inventory UI should review this before merging. |
BevapDin
reviewed
Jul 4, 2020
BevapDin
reviewed
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix zone sorting and category display in advanced inventory UI."
Purpose of change
Fix #41037
And also change category display in advanced inventory UI.
Describe the solution
Add a bool flag in get_category() that controls if we want to get category of the items itself, or it's contents. Set that flag too true in 3 places (false by default).
Describe alternatives you've considered
None.
Testing
Containers display correct category, depending on their contents.
Zone sorting seems to place containers in correct zones, depending on their contents.
Additional context