Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golf bag encumbrance #41281

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Conversation

CodeBandit
Copy link
Contributor

@CodeBandit CodeBandit commented Jun 13, 2020

Summary

SUMMARY: Bugfixes "Fix golf bag encumbrance"

Purpose of change

This is a follow up on #41259 to increase golf bag encumbrance since the main pocket is rigid. This made it so that a full golf bag still only had 2 encumbrance.

Describe the solution

Give the golfbag 25 flat encumbrance. It has 45L of volume, which is similar to a hiking backpack. However, the hiking backpack has 40 max encumbrance. This should balance it out. If not, atleast it fixes the golf bag permanently having 2 encumbrance.

Testing

None, straightforward change

@meladath
Copy link
Contributor

meladath commented Jun 13, 2020

The golf bag does not permanently have 2 encumbrance like you say, this is also a nerf not a fix.
Once the main rigid pocket of the golf bag is full, it gains encumbrance up to its max of 15 just like every other non rigid container. The problem with the golf bag is that the rigid pocket of the pocket bag is 42L of the 45L capacity of the bag itself.
A fix would be an increase to 14 that grows to 15, or just set it to 15.

I agree it needs rebalancing, but claiming its a fix is wrong. A lot of objects containers need rebalancing and/or JSON added since the nested overhaul.

@CodeBandit
Copy link
Contributor Author

Im not going to argue over the semantics of what a "fix" is. 15 encumbrance for 45L of carried space is unreasonable

@meladath
Copy link
Contributor

meladath commented Jun 13, 2020

Im not going to argue over the semantics of what a "fix" is.

Fix implies something is not working as intended.
You aren't fixing anything. It's not broken. You are changing a subjective setting. I agree its OP, but claiming its a "fix" is ludicrous. Check the blame, when was it changed? It needs a change, but it's not a "fix" because you think its unreasonable.

@kevingranade kevingranade merged commit 9078b84 into CleverRaven:master Jun 14, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Jun 14, 2020
@CodeBandit CodeBandit deleted the golf-bag branch June 14, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants