Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rigid items to affect relative encumbrance #41259

Closed
wants to merge 1 commit into from

Conversation

CodeBandit
Copy link
Contributor

@CodeBandit CodeBandit commented Jun 12, 2020

Summary

Summary: Bugfixes "Allow rigid items to affect relative encumbrance"

Purpose of change

Rigid pockets disregarded relative encumbrance. This is incorrect since a full and heavy container is more encumbering than an empty container, but this is not how it works in game right now.

For an actual example, brought to me by @meladath , a full golf bag, because its primary pocket is rigid, will always have a torso encumbrance of 2. That's essentially an insignificant amount of encumbrance for 45L of storage.

Describe the solution

Remove the check that ignores relative encumbrance if pocket is rigid.

Testing

Spawn a golf bag and fill up the rigid pocket. See that its encumbrance now increases.
Run unit tests, nothing failed.

@meladath
Copy link
Contributor

meladath commented Jun 12, 2020

But muh OP golf bag :'(
Anyone know if this code was originally intended or added in error?

@kevingranade
Copy link
Member

This is wrong, the reason it ignores rigid containers is that encumbrance from rigid pockets should be incorporated into the base encumbrance of the item. The encumbrance being calculated by this is not a product of weight and volume, it is just based on volume. Weight-based encumbrance is handled entirely separately.

@CodeBandit CodeBandit deleted the Golf-Bag branch June 13, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants