Fix crash at startup. #40377
Merged
Fix crash at startup. #40377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of storing it in a public variable, just make the code that uses it (**two** places only) call the function directly. This also gets rid of the initialization order bug (where the language path was set after the options had been loaded).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneThis actually fixes "When starting files in current directory are scanned recursively". Fixes #40356.
In my build the variable
options_manager::lang_optionsis initialized before the static variablelangdir_value, which causes a crash right at the start.This simply changes the code to do the language detection when needed (when options are initialized, which is done after
PATH_INFO::set_standard_filenames).May fix issue #40132 (I have no Android system to test this).