You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #40056 the current working directory is scanned for translations, it's thrashing the disk and slowing down launch. It should only scan the 'lang' subdirectory.
Steps To Reproduce
change directory (cd) to a directory with a lot of files/directories
Start 'strace -o output.log cataclysm'
The current directory is scanned recursively before displaying the menu
Observe lots of stat and related calls in output.log
Expected behavior
Only the 'lang' folder should be scanned recursively.
Versions and configuration
- OS: Linux (Arch up-to-date)
- Game Version: 0.E-1929-gfdb8229269 [64-bit]
- Graphics Version: Curses
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food]
]
Additional context
What happens is that PATH_INFO::langdir() is called at include-time, before PATH_INFO::set_standard_filenames() is called. That means that langdir_value = "", which means that the CWD will be scanned instead of the correct lang directory.
This is not really problematic if the current working directory is the game root (i.e. via cataclysm-launcher), but the game used to start fine directly from the binary and I think this is not expected behavior.
Problematic strace output
This recursive scan shouldn't happen (strace output) :
Describe the bug
Since #40056 the current working directory is scanned for translations, it's thrashing the disk and slowing down launch. It should only scan the 'lang' subdirectory.
Steps To Reproduce
stat
and related calls in output.logExpected behavior
Only the 'lang' folder should be scanned recursively.
Versions and configuration
Additional context
What happens is that PATH_INFO::langdir() is called at include-time, before PATH_INFO::set_standard_filenames() is called. That means that
langdir_value = ""
, which means that the CWD will be scanned instead of the correctlang
directory.This is not really problematic if the current working directory is the game root (i.e. via
cataclysm-launcher
), but the game used to start fine directly from the binary and I think this is not expected behavior.Problematic strace output
This recursive scan shouldn't happen (
strace
output) :The text was updated successfully, but these errors were encountered: