Generalize reduce_tests tool #40358
Merged
Generalize reduce_tests tool #40358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it worked only with one test executable, but when building with CMake you might have a different one. Use whichever is the most recently modified.
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
May 9, 2020
Merge pull request CleverRaven#40358 from jbytheway/generalize_reduce…
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Previously
reduce_testsworked only with one test executable (tests/cata_test), but when building with CMake you might have a different one.Describe the solution
Use whichever is the most recently modified.
Describe alternatives you've considered
Allow you to specify which you want.
Testing
Manually verified it now works with
cata_test-tileswhen that's newer.Additional context
I have a new way to build the CMake build which is much faster, so I want to be able to rely on that for my test reduction.