Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mi-go, necromancers, and masters can open doors #40065

Merged
merged 3 commits into from May 3, 2020
Merged

Mi-go, necromancers, and masters can open doors #40065

merged 3 commits into from May 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2020

Summary

SUMMARY: Content "Mi-go, masters, and necromancers can open doors"

Purpose of change

Most zombies aren't supposed to be smart enough to open doors. Zombie scientists still have the ability from before this lore was decided.
Mi-go are trapped in their base, due to having doors but not the ability to open them.

Describe the solution

Remove CAN_OPEN_DOORS from zombie scientists. Add door opening to mi-go faction, zombie necros, and zombie masters.

Describe alternatives you've considered

None.

Testing

Spawned in zombie scientist, it cannot open doors anymore.
Spawned in zombie necromancer & master, they can open doors.
Spawned in mi-go camp, opened resin portal so mi-go could spot me. They open the portal to pursue if closed.

Additional context

Original bug(from Devcord):
image

@Night-Pryanik
Copy link
Contributor

If no monster is using this flag anymore, then it should be removed from the code too.

@ghost
Copy link
Author

ghost commented May 2, 2020

I think it should be kept in for when ferals get their advanced versions, since it's canon that they can open doors. Otherwise the exact same code would just be added back in later.

Ferals Now The majority of feral humans are difficult to distinguish from zombies. They can grasp and use simple tools like clubs and melee weapons, and will avoid dangerous obstacles, open doors, and other very simple actions largely governed by motor memory, but that’s about it. These comprise around 1% of the zombie faction.

~Design doc

@Night-Pryanik
Copy link
Contributor

If you think it's appropriate, then add this ability to ferals. Otherwise it's a dead code, and we're removing the dead code from everywhere. There's no problem to return deleted code IF someone would like to add a monster which will utilize this ability.

@Wishbringer
Copy link
Contributor

There is likely many mods that already use the flag, something to consider.

@ghost ghost changed the title Remove dooropening ability from zombie scientists Swap door opening ability from scientists to feral runners May 2, 2020
@ghost
Copy link
Author

ghost commented May 2, 2020

Swapped door opening to feral runner, should its evolutions of predator and hunter also get it? Their descriptions both say their hands are rather mutated(or at least their fingers).

Either way, added PATH_AVOID_DANGER_2 to all 3 as it's also canonical that they know some level of danger avoidance per same quote.

Converting back to draft until I get feedback on if it should be DANGER_1 or 2.

@ghost ghost changed the title Swap door opening ability from scientists to feral runners Ferals are smart May 2, 2020
@ghost ghost marked this pull request as draft May 2, 2020 04:53
@Dacendeth
Copy link
Contributor

You know, this made me realize that mi-gos should probably be able to open doors, since it's kind of silly they have a base with doors they cant open.

@ymber
Copy link
Member

ymber commented May 2, 2020

These zombies aren't the ferals described in the design document. The whole runner line are blob reanimated dead. See the mon_zombie_runner description.

@Brian-Otten
Copy link
Contributor

Perhaps we could change the description so that they do match the design document? If they have the same name, and with this PR somewhat act like the runner line from the design document, we could make them fill that role and avoid some confusion. Then as we get some more of the AI code fleshed out we can expand the runner line with more variants.

@Tamiore
Copy link
Contributor

Tamiore commented May 2, 2020

You do realize that if feral predators start to avoid dangerous tiles, only very specific builds would actually have some sort of "play" against them in early game? (While everyone else will just get gutted.)

@mrkybe
Copy link
Contributor

mrkybe commented May 2, 2020

Ferals are zombies and zombies are supposed to be dumb. I could maybe see some danger avoidance for the 'feral predator'. None of them should be able to open doors though.

@kevingranade
Copy link
Member

Yea ferals aren't the right target for this either. Masters would be fine, necros would be fine, mi-go would be fine.

@ghost ghost marked this pull request as ready for review May 3, 2020 16:15
@ghost ghost changed the title Ferals are smart Mi-go, necromancers, and masters can open doors May 3, 2020
@ghost ghost marked this pull request as draft May 3, 2020 16:21
@ghost ghost marked this pull request as ready for review May 3, 2020 16:28
@ghost
Copy link
Author

ghost commented May 3, 2020

Changed per Kevin's advice & re-tested.

@kevingranade kevingranade merged commit fbf3b84 into CleverRaven:master May 3, 2020
@ghost ghost deleted the ZombieDoors branch May 3, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants