Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spurge seeds #40049

Merged
merged 2 commits into from
May 4, 2020
Merged

Add spurge seeds #40049

merged 2 commits into from
May 4, 2020

Conversation

Rail-Runner
Copy link
Contributor

@Rail-Runner Rail-Runner commented May 1, 2020

Summary

SUMMARY: Features "Add spurge seeds"

Purpose of change

Make recently-added plant replenishable, so that player won't run out of it if they stay in one place for a long time, and doesn't have to run around the wilderness to gather more.

I also wanted to add seeds for lotus plant too, but turns out they require rather unusual conditions to grow (that is, there has to be a layer of water where they're growing, with above-ground plant part floating on water) and currently those aren't supported properly, so I just removed generic "flower" seeds from its harvest entry.

Also remove the mention of burdock from wild herbs description, since it now exists as a separate item and plant.

Describe the solution

JSON editing.

Describe alternatives you've considered

Adding support for growing aquatic plants, like lotus is, though adding it for just one not-so-useful plant seems a bit much.

Testing

Not necessary; changes made are fairly straightforward.

Additional context

None.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels May 1, 2020
@curstwist
Copy link
Contributor

Don't forget to add to some item_groups for spawning.
ga_items_1 (community garden)
farming_seeds
trash

are all good choices.

@Rail-Runner
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants