Make event_source a polymorphic type #40040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every function in event_source was an if statement for the two different possibilities. This is a code smell that suggests we ought to be using two derived classes and dynamic dispatch instead. So, do that. No change to functionality intended.
ifreund
added
[C++]
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Every function in event_source was an if statement for the two different possibilities. This is a code smell that suggests we ought to be using two derived classes and dynamic dispatch instead.
Describe the solution
Do that.
As a side-effect, the
unique_valuestatistic gained support for both varieties ofevent_source.Describe alternatives you've considered
Leaving it as-is.
Testing
Unit tests.