make System language option work on macOS (fix getOSXSystemLang) #40034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
System language
option does not work on MacOS.CFStringGetCStringPtr
always returnNULL
. In Apple docs, I found that:https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFStrings/Articles/AccessingContents.html
Describe the solution
Add
CFStringGetCString
ifCFStringGetCStringPtr
returnsNULL
.Also, I replaced
reinterpret_cast
withstatic_cast
. Don't really know whyreinterpret_cast
is need here, if someone knows - feel free to change.Describe alternatives you've considered
Testing
System language
works correctly for MacOS.Additional context