game: don't drench the player if the player is in a boat

[mlangsdorf]

Summary

SUMMARY: Bugfixes "game: don't drench the player if the player is in a boat"

Purpose of change

Players in boats and amphibious vehicles get drenched for moving through water, even though being in a boat should hopefully keep their clothing dry.

Describe the solution

In game::place_player(), add a check for the player being in a vehicle that can float before calling drench().

Describe alternatives you've considered

place_player() is an awful function and needs to be refactored, and this particular part should probably be moved into the suffer() function.

Testing

Spawned a canoe and took it for a spin without getting soaked. Getting out of the boat into deep water drenched the character instantly.

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/walking-on-boat-hulls-or-around-a-boat-type-vehicle-gives-wet-debuff-and-plays-water-splash-sound-effect/23433/7

[Night-Pryanik]

Would player be drenched if he's sailing in a boat while it's raining?

[ZhilkinSerg]

Would player be drenched if he's sailing in a boat while it's raining?

Yeah - it is done in a different part of the code - do_rain and wet_player in weather.cpp.

[mlangsdorf]

This only prevents the drenching that occurs when the player is on a SWIMMABLE tile, so drenching from rain should still occur.