Enforce localized sorting #40012
Merged
Enforce localized sorting #40012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbytheway
force-pushed
the
enforce_localized_sorting
branch
from
4990f9a to
e9a9ace
Compare
It makes more sense to use an unordered_set for these objects, and it has the added advantage that it avoids a string comparison.
The intention is to detect cases where a simple string comparison is being performed, but a localized comparison would be more appropriate.
jbytheway
force-pushed
the
enforce_localized_sorting
branch
from
e9a9ace to
60372f0
Compare
mlangsdorf
added
Code: Infrastructure / Style / Static Analysis
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: I18N "Use localized sorting in more places"
Purpose of change
Improved internationalization / localization.
Describe the solution
Add a clang-tidy check to look for string comparisons that probably ought to be using localized rather than simple comparisons.
Resolve all the warnings it produces:
std::set" comparisons. I switched those to useunordered_setinstead.localized_compare(added in Localized sorting #39873)Describe alternatives you've considered
Could have gone further, but for this initial check I decided to just look at less-than comparison of
std::strings.Testing
Looked at some of the UIs affected. They seem to be working as expected.
Additional context
I wasn't able to find anyone else to test the changes from #39873, but I did test the Windows build under Wine, and it seemed to work as expected there, which is hopeful.