Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: add execute permission for build-data/osx/Cataclysm.sh #40009

Merged
merged 1 commit into from
Apr 29, 2020
Merged

HotFix: add execute permission for build-data/osx/Cataclysm.sh #40009

merged 1 commit into from
Apr 29, 2020

Conversation

akirashirosawa
Copy link
Contributor

@akirashirosawa akirashirosawa commented Apr 29, 2020

Summary

SUMMARY: None

Purpose of change

HotFix for #39971. After #39971 macOS can't execute Cataclysm.app, because build-data/osx/Cataclysm.sh and its copy on Cataclysm.app/Contents/MacOS/Cataclysm.sh does not have permission to execute.

Describe the solution

chmod +x build-data/osx/Cataclysm.sh

Describe alternatives you've considered

Testing

open Cataclysm.app w/o errors.

Additional context

Open error:

open Cataclysm.app 
LSOpenURLsWithRole() failed with error -10810 for the file ~/Cataclysm.app.

Old access permissions:

git revert 3c72197
ls data/osx/Cataclysm.sh
-rwxr-xr-x   data/osx/Cataclysm.sh

I did same access permissions for Cataclysm.sh in new osx specific data folder.

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system labels Apr 29, 2020
@ZhilkinSerg ZhilkinSerg merged commit f72177d into CleverRaven:master Apr 29, 2020
@akirashirosawa akirashirosawa deleted the osx-chmod-hotfix branch April 29, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants