Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appease clang-tidy #39999

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Appease clang-tidy #39999

merged 2 commits into from
Apr 28, 2020

Conversation

olanti-p
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

/home/runner/work/Cataclysm-DDA/Cataclysm-DDA/src/ascii_art.h:2:2: error: Header guard does not follow preferred style. [cata-header-guard,-warnings-as-errors]
#ifndef ASCII_ART_H
 ^      ~~~~~~~~~~~
        CATA_SRC_ASCII_ART_H

ifreund
ifreund suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the required comment to the #endif as well? should be

#endif // CATA_SRC_ASCII_ART_H

@olanti-p
Copy link
Contributor Author

Done

@olanti-p olanti-p requested a review from ifreund April 28, 2020 22:52
ifreund
ifreund approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ifreund ifreund merged commit 6c4120d into CleverRaven:master Apr 28, 2020
@olanti-p olanti-p deleted the fix-clang-tidy branch April 28, 2020 22:56
@SkuliAdams SkuliAdams mentioned this pull request Apr 28, 2020
Closed
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
@olanti-p @Drewscriver
Appease clang-tidy (CleverRaven#39999)
c906ca6 
* Appease clang-tidy

* Update ascii_art.h
This was referenced May 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifreund ifreund ifreund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olanti-p @ifreund