Exclude "potentially dangerous function" check. #39965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
commented
Apr 27, 2020
kevingranade
commented
Apr 27, 2020
kevingranade
commented
Apr 29, 2020
kevingranade
commented
Apr 29, 2020
|
Hmm, looks like LGTM didn't run on the latest commit for some reason |
|
Yea neither the final nor the penultimate version. |
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: None
Just some LGTM cleanup, there's nothing to be done about these functions and they aren't dangerous in our use case.
I'm mostly opening as a PR because I'm not 100% sure abut the LGTM yaml.