Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FN F2000 rifle #39926

Closed
wants to merge 2 commits into from
Closed

Added FN F2000 rifle #39926

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2020

Summary

SUMMARY: Content "Add FN F2000 assault rifle"

LZhangy added 2 commits April 25, 2020 19:53
Added to .223 guns and military loot table
@ymber
Copy link
Member

ymber commented Apr 26, 2020

F2000s don't belong in the setting. They're restricted title 2 weapons and they've never been in service with the American military or any police forces in the region.

@ghost
Copy link
Author

ghost commented Apr 26, 2020

F2000s don't belong in the setting. They're restricted title 2 weapons and they've never been in service with the American military or any police forces in the region.

So by that logic, power armor and laser rifles also shouldn't exist because they aren't used by the American military? Not to mention there is a whole branch of FN in the United States and we already have another foreign rifle like the FAMAS in the game? Your reasoning as to why the lack of usage of this weapon by the majority of the armed forces in the United States equates to it being unsuitable as content isn't very convincing.

@FuelType-Memes
Copy link
Contributor

FuelType-Memes commented Apr 26, 2020

I would point out, that "if we have X why can't we add Y?" line of reasoning in general leads to the removal or correction of X

@Night-Pryanik
Copy link
Contributor

There is already #36838 adding almost the same weapon.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tl:dr; Don't ignore the content issues from the first(#36281) or second(#36436) times.

Not in comments:
Add a Generic Guns migration entry.

Comment on lines +19 to +22
"ranged_damage": {
"damage_type": "stab",
"amount": -1
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo every change to the ranged_damage, modes, or magazines of every non-F2000.

Comment on lines +172 to +175
{
"item": "m16a4",
"prob": 5
},
Copy link

@ghost ghost Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo this as well

Comment on lines +176 to +179
{
"item": "fn_f2000",
"prob": 5
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The F2000 was never used by the U.S. military at any point. This would be in guns_rifle_rare

Comment on lines +172 to +173
"weight": "3400 g",
"volume": "1700 ml",
Copy link

@ghost ghost Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"weight": "3400 g",
"volume": "1700 ml",
"weight": "3319 g",
"volume": "7986 ml",

From #36838.

Comment on lines +193 to +197
"magazines": [
[
"223",
[ "stanag30", "stanag50", "survivor223mag" ]
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"magazines": [
[
"223",
[ "stanag30", "stanag50", "survivor223mag" ]
]
"magazines": [ [ "223", [ "stanag30", "stanag50", "survivor223mag" ] ],
"magazine_well": "228 ml"

@ymber
Copy link
Member

ymber commented Apr 26, 2020

Not an appropriate content addition. Closing in favor of #36838.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants