Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attack of the tentacle dogs #39918

Merged
merged 4 commits into from
May 4, 2020

Conversation

Aloxaf
Copy link
Contributor

@Aloxaf Aloxaf commented Apr 26, 2020

Summary

SUMMARY: Bugfixes "Fix attack of the tentacle dogs"

Purpose of change

mattack::tentacle hardcodes the target as the player. So the player will be hurt even if the dog is attacking an NPC.
And it's attack also ignores the armor and distance. (Considering its baseline difficulty is 0, I don't think this is a feature)

Describe the solution

  1. Don't hardcode the target and limit its attack range to 3.
  2. Set its baseline difficulity to 2.

Describe alternatives you've considered

Keep it as a feature?

Testing

  1. Spawn an NPC.
  2. Spawn a tentacle dog.
  3. Let them fight.

Before
图片

After
图片

Additional context

src/monattack.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Anton Burmistrov <[email protected]>
@mlangsdorf mlangsdorf added the Monsters Monsters both friendly and unfriendly. label Apr 30, 2020
@mlangsdorf
Copy link
Contributor

Thank you for fixing another stupid hardcoded monster attack bug.

src/monattack.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 5307883 into CleverRaven:master May 4, 2020
@Aloxaf Aloxaf deleted the fix_tentacle_attack branch May 6, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants