Intelligence affects exp rates based on current int, not max int #39902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is already done in |
Thanks for pointing that out! I took a look and it does look to be doing that. I changed the functionality to go from get_int_base() to get_int() so it's actually using the player's current int value instead of the player's max int. Changing the PR to a bug-fix. |
CodeBandit
changed the title
|
|
curstwist
added
<Bugfix>
Drewscriver
pushed a commit
to Drewscriver/Cataclysm-DDA
that referenced
this pull request
Apr 30, 2020
…verRaven#39902) * change int effect from base to current
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Use current int instead of max int for exp calculations"Purpose of change
Leverage get_int() instead of get_int_base() so the player's current int is used instead of maximum int for experience calculation. If the player currently has 0 int due to debuffs, they shouldn't be retaining information as well as if they had 8 int (assuming that's their max base int).
Describe the solution
Change get_int_base() to get_int()