Fix items having inappropriate charges in chargen #39898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demoragon
changed the title
ifreund
added
<Bugfix>
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix items with inappropriate charges in chargen"Purpose of change
Fixes #39176 - half-full magazines and other items with inappropriate charges in chargen.
Describe the solution
This bug is caused by some code in profession.cpp, that used to fix bullets & batteries randomizing their numbers in chargen (#38675). But now this problem is solved differently and it looks like this part of code is just useless.
Describe alternatives you've considered
Testing
Deleted this part of code, compiled the game, made sure, that items have appropriate charges, which are defined in professions.json
Additional context
Gangster profession with items having appropriate charges.
