Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds recipe for makeshift leather hose. #39882

Merged
merged 6 commits into from
Apr 27, 2020

Conversation

Tamiore
Copy link
Contributor

@Tamiore Tamiore commented Apr 25, 2020

Plastic for body, duct tape for flexibility, same difficulty as plastic bottles and the like.
A hose, made of leather.

Summary

SUMMARY: Content "Adds recipe for makeshift leather hose."

Purpose of change

Removes crafting bottleneck that prevents players from crafting basic chemistry set (and a few other key items).

Describe the solution

Adds the recipe for makeshift leather hose.
Made from leather, filament and some superglue.

Describe alternatives you've considered

Adding a recipe for "makeshift hose". Seems unnecessary, as other home-made plastic items are not distinguished from factory-made.

Update: after some discussion, that's exactly what the new PR does. But it's made out of leather now.

Testing

JSON edit, works fine locally.

Plastic for body, duct tape for flexibility, same difficulty as plastic bottles and the like.
@Fris0uman
Copy link
Contributor

Fris0uman commented Apr 25, 2020

Can you really make a rubber hose by ductaping some chunk of plastic together?

Adding a recipe for "makeshift hose". Seems unnecessary, as other home-made plastic items are not distinguished from factory-made.

It's not because existng items are wrong that new items should be too.

@int-ua
Copy link
Contributor

int-ua commented Apr 25, 2020

#39800

@Tamiore
Copy link
Contributor Author

Tamiore commented Apr 25, 2020

Can you really make a rubber hose by ductaping some chunk of plastic together?
It's not because existng items are wrong that new items should be too.

Recipe still uses plastic molding equipment. The idea is that you mold segments of the hose the same way you mold plastic bottles, etc. And as you do, you integrate duct tape to provide flexibility.

This should work to create some sort of a viable "hose".

If you think if should be a separate item from "normal" rubber hose, I can probably do that. But then I need a more clear distinction of what the actual limitations of such "makeshift" hose are.
What makes it functionally different from the hose you can salvage from a random fridge?

@curstwist curstwist added Accessibility Issues regarding accessibility Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON and removed Accessibility Issues regarding accessibility labels Apr 25, 2020
@enaantd
Copy link
Contributor

enaantd commented Apr 25, 2020

I'm not sure a handmade hose with duct tape would stay watertight for long, especially since when using a rubber hose you bend it in all kinds of angles. maybe we can keep the idea of a makeshift rubber hose but make it way less durable?
EDIT: maybe you can use the same system than improvised lockpicks, where it's got a chance of losing durability after each use

Adds craftable makeshift plastic hose for those recipes where it will be good enough.
Not a substitute for rubber hose as a tool for fuel siphoning.
@Tamiore Tamiore changed the title Adds recipe for rubber hose. Adds recipe for makeshift hose. Apr 25, 2020
@Tamiore
Copy link
Contributor Author

Tamiore commented Apr 25, 2020

Based on feedback, I've added a makeshift plastic hose (instead of the original idea that just straight up allowed to craft rubber hose).

Key difference:

  • explicitly made out of plastic
  • not usable as a tool for siphoning fuel (not flexible enough)
  • can be used as a substitute for rubber hose in crafting, but only in recipes where it's lower flexibility and durability seem largely irrelevant
  • no longer made out of rubber, so does not conflict with add rubber #39800

@Xanderga
Copy link
Contributor

I don't feel adding a makeshift hose recipe just to be used as a crafting material for basic chemistry sets is a good idea. Rubber hoses are extremely far from being a bottle neck -raiding 3 houses and smashing 3 fridges takes a good few minutes worth of in game time. I just don't want to see another "obsolete makeshift recipes" PR for cleanup purposes

@Tamiore
Copy link
Contributor Author

Tamiore commented Apr 26, 2020

I don't feel adding a makeshift hose recipe just to be used as a crafting material for basic chemistry sets is a good idea. Rubber hoses are extremely far from being a bottle neck -raiding 3 houses and smashing 3 fridges takes a good few minutes worth of in game time.

This is only the case if you are not playing some kind of wilderness scenario (no houses) and/or a scenario where going to a city is actually very dangerous. When you do, rubber hoses suddenly become the bottleneck.
The whole idea behind removing "crafting bottlenecks" is to allow reasonable substitutes — exactly for scenarios/playstyles that do not operate under "default" resource availability.

I just don't want to see another "obsolete makeshift recipes" PR for cleanup purposes.

Again, it's only "obsolete" if you play with default resource availability. But by that logic most food recipes are also "obsolete", since you are basically showered with food with default settings.

@anothersimulacrum
Copy link
Member

The justification for this should be that a rubber hose or something with similar enough properties is possible to make with the existing tools (and if it's not, adding those tools), not that there's a bottleneck in crafting. If you can't craft it, you can't craft it, the bottleneck isn't a problem.

@Tamiore
Copy link
Contributor Author

Tamiore commented Apr 26, 2020

The justification for this should be that a rubber hose or something with similar enough properties is possible to make with the existing tools (and if it's not, adding those tools), not that there's a bottleneck in crafting. If you can't craft it, you can't craft it, the bottleneck isn't a problem

Justification for the "can you craft it" part here basically boils down to the fact plastic tube is not really different from plastic bottle or plastic jug.
Extra flexibility can be added via duct tape. (And I don't mean by simply duct taping tube segments when they are already cold, but rather by fusing tape and plastic together as you mold it.)
If you feel like the whole "fusing" part is dubious, I can add superglue to the recipe for extra reinforcement of duct tape adhesion.

@Rail-Runner
Copy link
Contributor

Rail-Runner commented Apr 26, 2020

Perhaps a leather hose could be a better improvised option.

From what I could find, such hoses are usually used for hookahs, so they are supposedly liquid-proof and gas-proof. I figure they'd have just two drawbacks compared to rubber hoses: they aren't really that stretchable (so can't use it for things like slingshots), and they may be less resistant to aggressive materials (like acids), so may be less useful for chemistry projects involving gases like chlorine.

Such a hose would also likely need some waterproofing material to craft, along with leather (likely oil, tallow or wax, so that you don't need to use modern materials to make one)

For chemistry projects, if leather hose fails to work, you probably could use a glass pipe instead, since flexibility isn't necessary for this.

@CodeBandit
Copy link
Contributor

I agree with @Rail-Runner . Since your point seems to be to add a viable alternative to characters playing with resources out of reach, then use leather instead of putting together plastic pieces with some duct tape. Crafting time should be relatively long.

The community has spoken!
@Tamiore Tamiore changed the title Adds recipe for makeshift hose. Adds recipe for makeshift leather hose. Apr 26, 2020
@Tamiore
Copy link
Contributor Author

Tamiore commented Apr 26, 2020

Changed recipe into into leather hose.

Made from leather, filament and some superglue to make it completely watertight after sewing it together.

Such a hose would also likely need some waterproofing material to craft, along with leather (likely oil, tallow or wax, so that you don't need to use modern materials to make one)

Something "oily" is already used when tanning leather, so requiring it again seems redundant. Plus, other watertight items made of leather (e.g. waterskins) don't require extra 'oiling".

@enaantd
Copy link
Contributor

enaantd commented Apr 26, 2020

I think @Rail-Runner meant that when you create a leather tube from a leather patch you're going to need to glue it somewhere, and this junction needs to be waterproof. It's not so much about waterproofing the leather itself

@Tamiore
Copy link
Contributor Author

Tamiore commented Apr 26, 2020

I think @Rail-Runner meant that when you create a leather tube from a leather patch you're going to need to glue it somewhere, and this junction needs to be waterproof. It's not so much about waterproofing the leather itself

Feels like superglue itself makes more sense for that, no?

@enaantd
Copy link
Contributor

enaantd commented Apr 26, 2020

@Tamiore absolutely, I was just pointing that some glue was required :) superglue seems fine to me

@CodeBandit
Copy link
Contributor

Perhaps use Bone glue as well? It's thematically consistent and another viable alternative to superglue.

@Tamiore
Copy link
Contributor Author

Tamiore commented Apr 26, 2020

Perhaps use Bone glue as well? It's thematically consistent and another viable alternative to superglue.

As far as I know, most animal glues are water-soluble, and, thus, are not waterproof.

Hide glue in its various forms has a modulus of eruption slightly less than (pardon me) epoxy but it is not waterproof.

http://www.fullchisel.com/blog/?p=52

@kevingranade kevingranade merged commit caf81ee into CleverRaven:master Apr 27, 2020
@Tamiore Tamiore deleted the DIY_rubber_hose branch April 27, 2020 04:41
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants