Fix crash when opening action menu with guns in inventory #39408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix crash when opening action menu with guns in inventory"
Purpose of change
Fixes #39403.
item::get_use
callsvisit_items
, which ignores the item content if it is a gun or magazine, whereasitem::get_usable_item
callscontents.visit_contents
, which iterates over the item content regardless of the item type. So when initializing the action menu,item::get_usable_item
returns the item content if it has the wanted use action, butitem::get_use
returns null if the item is a gun. Dereferencing the return value causes the game to crash.Describe the solution
Use
visit_items
initem::get_usable_item
so content of guns and magazines are ignored.Testing
Loaded the attached save from #39403, opened item action menu, and the crash no longer happened.