Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Generic Guns) BP Migrations & Recipes #39152

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

tenmillimaster
Copy link
Member

Summary

SUMMARY: Mods "Migrates blackpowder ammo & adds recipes for generic guns"

Purpose of change

44 Army, 36 navy ammunition were incorrectly being migrated to flintlock paper cartridges, which itself should have been migrated. There were no ways to craft the correct ammo for the antique (revolver/pistol/rifle).

Fixes #39133.

Describe the solution

Corrected the migration for 44 army, 36 navy, and flintlock ammo to migrate to (generic guns) paper cartridges. Added recipes for the generic guns paper cartridges.

Describe alternatives you've considered

None.

Testing

Loaded game, created new GG world, spawned relevant firearms, and reloaded it with the spawned black_powder_ball and black_powder_shot cartridges. Debug learned all recipes and observed that I could now craft the relevant ammo.

@tenmillimaster tenmillimaster added [JSON] Changes (can be) made in JSON Mods: Generic Guns Anything to do with Generic Guns Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves and removed Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Apr 1, 2020
@KorGgenT KorGgenT merged commit abb41f8 into CleverRaven:master Apr 2, 2020
@tenmillimaster tenmillimaster deleted the GG-bp branch April 3, 2020 20:15
@anothersimulacrum anothersimulacrum mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON Mods: Generic Guns Anything to do with Generic Guns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with paper cartridge (with generic guns)
2 participants