Add test asserting that time to throw is independent of size of thrown item stack size #39092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n item stack size
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Simple regression test for #39090
Cost to throw an item unexpectedly depended on wielded stack size, prevent that from accidentally recurring.
Describe the solution
Have a player wield a stack of items and check time to throw while decreasing stack size.
Testing
Revert a0fe8c1 and run this test, you can see it fail.
Un-revert a0fe8c1 and run the test, and it passes.
Additional context
Easy to extend this to multiple item types, but I don't see a reason at the moment.