Fix movement cost for throwing stacking items #39090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix throwing movement cost for stacking items like bola/net/throwing stick."
Purpose of change
Fixes #39077
Describe the solution
Like I explained in #39077, the problem was itemp.cpp attack_time() formula using full stack weight/volume instead of a single item. I just added a division to the formula to divide that part by the stack item count.
Describe alternatives you've considered
I checked if any existing method I could returned volume/weight for single item so I could reuse them, but they don't exist.
Testing
Tested in a local build, before the change, throwing a bola from a stack of 3 costed 170, 130 for the first 2 throws, now it cost 70 for every throw (at least for my testing character, numbers may vary for other char).