-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window manager for properly refreshing and resizing multiple layers of windows #37894
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| #include "ui_manager.h" | ||
|
|
||
| #include <vector> | ||
|
|
||
| #include "cursesdef.h" | ||
| #include "point.h" | ||
| #include "sdltiles.h" | ||
|
|
||
| static std::vector<std::reference_wrapper<ui_adaptor>> ui_stack; | ||
|
|
||
| ui_adaptor::ui_adaptor() : invalidated( false ) | ||
| { | ||
| ui_stack.emplace_back( *this ); | ||
| } | ||
|
|
||
| ui_adaptor::~ui_adaptor() | ||
| { | ||
| for( auto it = ui_stack.rbegin(); it < ui_stack.rend(); ++it ) { | ||
| if( &it->get() == this ) { | ||
| ui_stack.erase( std::prev( it.base() ) ); | ||
| // TODO avoid invalidating portions that do not need to be redrawn | ||
| ui_manager::invalidate( dimensions ); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void ui_adaptor::position_from_window( const catacurses::window &win ) | ||
| { | ||
| const rectangle old_dimensions = dimensions; | ||
| // ensure position is updated before calling invalidate | ||
| #ifdef TILES | ||
| const window_dimensions dim = get_window_dimensions( win ); | ||
| dimensions = rectangle( dim.window_pos_pixel, dim.window_pos_pixel + dim.window_size_pixel ); | ||
| #else | ||
| const point origin( getbegx( win ), getbegy( win ) ); | ||
| dimensions = rectangle( origin, origin + point( getmaxx( win ), getmaxy( win ) ) ); | ||
| #endif | ||
| invalidated = true; | ||
| ui_manager::invalidate( old_dimensions ); | ||
| } | ||
|
|
||
| void ui_adaptor::on_redraw( const redraw_callback_t &fun ) | ||
| { | ||
| redraw_cb = fun; | ||
| } | ||
|
|
||
| void ui_adaptor::on_screen_resize( const screen_resize_callback_t &fun ) | ||
| { | ||
| screen_resized_cb = fun; | ||
| } | ||
|
|
||
| static bool contains( const rectangle &lhs, const rectangle &rhs ) | ||
| { | ||
| return rhs.p_min.x >= lhs.p_min.x && rhs.p_max.x <= lhs.p_max.x && | ||
| rhs.p_min.y >= lhs.p_min.y && rhs.p_max.y <= lhs.p_max.y; | ||
| } | ||
|
|
||
| static bool overlap( const rectangle &lhs, const rectangle &rhs ) | ||
| { | ||
| return lhs.p_min.x < rhs.p_max.x && lhs.p_min.y < rhs.p_max.y && | ||
| rhs.p_min.x < lhs.p_max.x && rhs.p_min.y < lhs.p_max.y; | ||
| } | ||
|
|
||
| void ui_adaptor::invalidate( const rectangle &rect ) | ||
| { | ||
| if( rect.p_min.x >= rect.p_max.x || rect.p_min.y >= rect.p_max.y ) { | ||
| return; | ||
| } | ||
| // TODO avoid invalidating portions that do not need to be redrawn | ||
| for( auto it = ui_stack.crbegin(); it < ui_stack.crend(); ++it ) { | ||
| const ui_adaptor &ui = it->get(); | ||
| if( overlap( ui.dimensions, rect ) ) { | ||
| ui.invalidated = true; | ||
| if( contains( ui.dimensions, rect ) ) { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void ui_adaptor::redraw() | ||
| { | ||
| // TODO refresh only when all stacked UIs are drawn | ||
| if( !ui_stack.empty() ) { | ||
| ui_stack.back().get().invalidated = true; | ||
| for( const ui_adaptor &ui : ui_stack ) { | ||
| if( ui.invalidated ) { | ||
| if( ui.redraw_cb ) { | ||
| ui.redraw_cb( ui ); | ||
| } | ||
| ui.invalidated = false; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void ui_adaptor::screen_resized() | ||
| { | ||
| for( ui_adaptor &ui : ui_stack ) { | ||
| if( ui.screen_resized_cb ) { | ||
| ui.screen_resized_cb( ui ); | ||
| } | ||
| } | ||
| redraw(); | ||
| } | ||
|
|
||
| namespace ui_manager | ||
| { | ||
|
|
||
| void invalidate( const rectangle &rect ) | ||
| { | ||
| ui_adaptor::invalidate( rect ); | ||
| } | ||
|
|
||
| void redraw() | ||
| { | ||
| ui_adaptor::redraw(); | ||
| } | ||
|
|
||
| void screen_resized() | ||
| { | ||
| ui_adaptor::screen_resized(); | ||
| } | ||
|
|
||
| } // namespace ui_manager |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently sometimes
gcould be empty when there are errors (see #39258), so we need to check for non-emptiness prior to comparingwinwith members ofg, e.g.:window_dimensions dim; dim.scaled_font_size.x = fontwidth; dim.scaled_font_size.y = fontheight; if( g ) { if( use_tiles && win == g->w_terrain ) { // tiles might have different dimensions than standard font dim.scaled_font_size.x = tilecontext->get_tile_width(); dim.scaled_font_size.y = tilecontext->get_tile_height(); } else if( map_font && win == g->w_terrain ) { // map font (if any) might differ from standard font dim.scaled_font_size.x = map_font->fontwidth; dim.scaled_font_size.y = map_font->fontheight; } else if( overmap_font && win == g->w_overmap ) { dim.scaled_font_size.x = overmap_font->fontwidth; dim.scaled_font_size.y = overmap_font->fontheight; } }