Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More repairs like flags #37073

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

Brian-Otten
Copy link
Contributor

@Brian-Otten Brian-Otten commented Jan 15, 2020

Summary

SUMMARY: Bugfixes "Adds repairs like flag to uncraftable armors"

Purpose of change

Fixes #36761
With recent changes it became impossible for uncraftable armor with no repairs_like flag to be repaired.

Describe the solution

Add repairs_like flag with a suitable item to every armor that needed it i could find. By my count 179 items.

Describe alternatives you've considered

Having someone else add repairs_like flags and ids for 5 hours.

Additional context

I tried to use a close match for the repairs_like flag, but i didn't get a "perfect" match on many items. Someone should be easily able to add even better fitting repairs_like flags after this has merged.

Attempted to match items with same slot item with same material.
@Zireael07
Copy link
Contributor

The first commit was funny - miner hat, really? You probably could roll those two commits into one (google git squash) so that we don't have such a funny commit in the repo history once it (hopefully) gets merged.

@Brian-Otten
Copy link
Contributor Author

Heh, copy pasting one line in everywhere so i only had to swap the ids in later after i had found all the needed armors was the fastest way to get it done at the time.
I'll see about git squash, but am going to get some sleep first, and perhaps i can find some time to figure it out tomorrow. If i don't get to it in time one weird commit shouldn't hurt much.

@anothersimulacrum
Copy link
Member

If you add Fixes #36761 to your first post, when this PR is merged, that issue will be automatically closed.

@Brian-Otten
Copy link
Contributor Author

I wasn't 100% sure i got everything in one go, but it's probably good enough. Will edit it in.

@kevingranade kevingranade merged commit c1caf59 into CleverRaven:master Jan 17, 2020
@RarkGrames
Copy link
Contributor

I think you need to recheck this whole thing. The miner_hat entry is still on a lot of clothes as of build 10243. Like for example on wedding veil or utility vest. An other thing I noticed that you used entries that look similar, rather than entries that use the same materials or the same tailoring technique. I.e. repairing a nylon fencing jacket is not the same as repairing a boiled leather armor.

@Brian-Otten Brian-Otten mentioned this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repairing uncraftable armor/clothes is currently too hard
5 participants