Repairing uncraftable armor/clothes is currently too hard

[Brian-Otten]

Describe the bug

Repairing of uncraftable armor/clothes is not reasonably possible for most/all players, even with endgame skills.

Steps To Reproduce

Spawn army pants/sheriff shirt/ rollerblades/ other uncraftable armors.
Set tailoring to 8.
Try to refit/repair clothes with tailor kit
See that the success chance is for repair/refit is 0% or far lower than than the damage chance.

Expected behavior

Uncraftable clothing repair chance is based on the material it is made from. This would keep repairs in line with what your character could craft. Alternatively reduce the difficulty slightly so endgame characters can repair their sentimental value sheriff shirt.

Versions and configuration

• OS: Windows
  • OS Version: 10.0 1903
• Game Version: 0.D-11048-g8ad1db2 [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Craftable Gun Pack [craftgp],
  Makeshift Items Mod [makeshift],
  Medieval and Historic Classes and Shields [Medieval_Stuff],
  More Survival Tools [More_Survival_Tools],
  EZ-Mode Medical [fast_healing],
  No Rail Stations [No_Rail_Stations],
  Folding Parts pack [deoxymod],
  Vehicle Additions Pack [blazemod],
  Tanks and Other Vehicles [Tanks],
  Roadheader and other mining vehicles [Heavy miners],
  No Acid Zombies [No_Acid_Zombies],
  No Explosive Zombies [No_Explosive_Zombies],
  No Fungal Monsters [No_Fungi],
  Safe Autodoc [safeautodoc],
  Manual Bionic Installation [manualbionicinstall],
  SpeedyDex [speedydex],
  Stats Through Kills [stats_through_kills]

[anothersimulacrum]

So, what's happening here is that items without a recipe have their recipe difficulty difficulty set to 10 - this is new after #36700, even though the comment says that it was set to 10, it was actually set to 5.

[ghost]

Quick glance with blame shows that value was changed between dbf9aeb and b70a6a4 without updating comment about difficulty.
NB. Making uncraftable items repair difficulty 10 makes them unrepairable, this was clearly unintended and subsequently fixed.

[anothersimulacrum]

With repairs_like, I think we should keep it at 10 and add a repairs_like to the things that are too difficult.

[ghost]

So - vast majority of uncraftable items. That would be fine in theory and perhaps a good long term goal, but in the meantime it leaves almost every uncraftable item unrepairable. Then there is the issue of NO_REPAIR flag existence.

[Brian-Otten]

So that pr should hopefully fix it and it only took a bit of blood sweat and tears.