Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extended pickup window #36593

Merged
merged 11 commits into from
Jan 2, 2020
Merged

Fix extended pickup window #36593

merged 11 commits into from
Jan 2, 2020

Conversation

8street
Copy link
Contributor

@8street 8street commented Dec 31, 2019

Summary

SUMMARY: Bugfixes "Fix extended pickup window"

Purpose of change

When you turn the page in the pickup window, sometimes long names remain as residual text. PR fix this.

Describe the solution

I'd created dynamic length of the clear buffer instead fixed const clear string.

Describe alternatives you've considered

for( int cur_row = 1; cur_row < pickupH; cur_row++ ) {
   for( int cur_column = 0; cur_column < pickupW; cur_column++ ) {
      mvwprintw( w_pickup, point( cur_column, cur_row ), " " );
   }
}

Very slow.

wclear( w_pickup );
wclear() remove weight at the top of the window.

Testing

Before
fix1

After
fix2

src/pickup.cpp Outdated Show resolved Hide resolved
some cosmetic fix

Co-Authored-By: Anton Burmistrov <[email protected]>
src/pickup.cpp Outdated Show resolved Hide resolved
@8street 8street changed the title Fix extended pickup window [WIP] Fix extended pickup window Dec 31, 2019
@8street 8street changed the title [WIP] Fix extended pickup window Fix extended pickup window Jan 1, 2020
@kevingranade kevingranade merged commit d2e8c25 into CleverRaven:master Jan 2, 2020
@8street 8street deleted the Fix-extended-pickup-window branch January 10, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants