Fix mysterious creation of submap (0,0,-9). #36582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the key does not exist in the map, it is added its value is automatically initialized anyway.
Much simpler and does not need magic values. fixup iterationg
The class takes care of storing the temporary submaps (and deleting them) and it will also not save them into the global mapbuffer.
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneI was wondering why my save had a map folder ("save/World/maps/0.0.0") for the map at (0,0,0), through I was never even near that coordinate. Even more perplexing, it has a folder for the coordinate (0,0,-9), but no folder for the maps around those. How were those maps created? And why? It's probably aliens, but I wanted to know which aliens.
Turns out this comes from automatically calculating "recipes". Here is the back trace:
The really funny thing is the comment at the top of
tinymap::fake_load:It than proceeds to call
generate_uniform, which explicitly callsMAPBUFFER.add_submap(which is basically saving the submap).It even checks that the submap created by that function was properly registered within the
MAPBUFFERby looking it up again.