Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo that caused unvisited json members #35686

Merged
merged 3 commits into from
Nov 24, 2019
Merged

Fix typo that caused unvisited json members #35686

merged 3 commits into from
Nov 24, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Nov 23, 2019 •
edited
Loading

Summary

SUMMARY: None

Purpose of change

Fix typo.

Describe the solution

Describe alternatives you've considered

Testing

Start game without error

Additional context

@ZhilkinSerg
Copy link
Contributor

The json is fine. There is a typo in #35638:

optional( jo, was_loaded, "message_type", fe.env_message_type, game_message_type_reader );

should be joe, instead of jo.

@Fris0uman Fris0uman changed the title Remove unvisited json members Fix typo that caused unvisited json members Nov 23, 2019
@kevingranade kevingranade merged commit 1a06c34 into CleverRaven:master Nov 24, 2019
@Fris0uman Fris0uman deleted the urnreach branch November 24, 2019 09:01
@weekly-digest weekly-digest bot mentioned this pull request Nov 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fris0uman @ZhilkinSerg @kevingranade