Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize weather into the main game save. #35661

Merged
merged 6 commits into from
Nov 23, 2019

Conversation

BevapDin
Copy link
Contributor

SUMMARY: None

Instead of a separate file (specific for each player, so each player had their own weather).

And that file used a cryptic format as well.

This ensures each character in the world has the same weather.

And save it as JSON data.
The function contains character-by-character the same.
@ralreegorganon
Copy link
Contributor

It doesn't really matter, but since you're moving the seed, it'd be kinda nice if it wasn't inside the weather object in the serialized form, since it's not really just about weather. It was originally added for the weather to seed the simplex noise, but now it's just become the general purpose seed retrieved from game::get_seed(), and is used for things like mapgen as well.

@kevingranade kevingranade merged commit f374f21 into CleverRaven:master Nov 23, 2019
@BevapDin BevapDin deleted the jvy branch November 23, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants