Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete bio_solar removal #35645

Merged
merged 2 commits into from
Nov 23, 2019

Conversation

Fris0uman
Copy link
Contributor

Summary

SUMMARY: Content "Complete bio_solar removal"

Purpose of change

Solar panel actually lives under the bn_bio_solar id
bio_solar has been removed from saves by #23317 which was more than a year ago
This removes the remaining references to bio_solar

Describe the solution

Search for bio_solar and remove it

Describe alternatives you've considered

Testing

Additional context

@Maleclypse
Copy link
Member

So I know the CBM is still in Aftershock are there any lines from what you are removing that I need to carry over to Aftershock to keep it working there?

@anothersimulacrum
Copy link
Member

It's bn_bio_solar in Aftershock, shouldn't need to do anything.

@Maleclypse
Copy link
Member

I was hoping that was the case. Thanks!

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) labels Nov 22, 2019
@ZhilkinSerg
Copy link
Contributor

There is a reference to bio_solar somewhere in savegame code and that is probably what fails tests on CI.

@kevingranade kevingranade merged commit dba86fe into CleverRaven:master Nov 23, 2019
@Fris0uman Fris0uman deleted the solar_panel_obsoletion branch November 23, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants