Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRE food list and Military List clean up #35640

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

LilShiningMan
Copy link
Contributor

SUMMARY: Content "MRE List added. Military item groups clean up"

Summary

Added MRE list to food.json. Cleaned up a couple military item lists.

Purpose of change

De-cluttering item group spawn lists.

Describe the solution

Created MRE list in food.json. Added list to mil_food_no_drugs; replaced redundant entries in mil_food by calling mil_food_nodrugs; replaced redundant entries in military list by calling mil_food and also mil_armor list. It looks like a couple lists were copy-pasted together from other groups and so had a small number of entries that appeared twice in lists, so removed redundant entries, including in mil_armor.

Describe alternatives you've considered

Testing

De-linted jsons. Spawned item groups in game. No issues.

Additional context

@LilShiningMan
Copy link
Contributor Author

Almost forgot: eliminated 114 redundant entry lines.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Nov 22, 2019
@ZhilkinSerg ZhilkinSerg merged commit dc3a1bf into CleverRaven:master Nov 22, 2019
@LilShiningMan LilShiningMan deleted the LSM---MRE-List branch December 7, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants