Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shockwaves don't cross z-levels #35628

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Nov 20, 2019

Summary

SUMMARY: Bugfixes "Shockwaves don't cross z-levels"

Purpose of change

Fixes #29851
Shockwave don't affect other z-level and won't teleport zombies around

Describe the solution

Check if creature is on same z-level as point of origin, if not skip that creature

Describe alternatives you've considered

Add checks to not push monster through walls or on the same tile as an other monster as I suppose that's what was making them teleport but I didn't manage to figure it out

Testing

Fill basement of shelter with zombies
Activate the shockwave from upstairs
Before fix -> 3 zombies teleported
After fix -> No zombie affected by the shockwave

Additional context

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) labels Nov 22, 2019
@ZhilkinSerg ZhilkinSerg merged commit 287240a into CleverRaven:master Nov 22, 2019
@Fris0uman Fris0uman deleted the shock_z branch November 22, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shockwave generator CBM sometimes teleports enemies to current z-level
2 participants