Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yowshi #35619

Closed
wants to merge 5 commits into from
Closed

yowshi #35619

wants to merge 5 commits into from

Conversation

yowshi
Copy link
Contributor

@yowshi yowshi commented Nov 20, 2019

Summary

SUMMARY: Added soap flakes recipe which could be used in a washing machine.

Purpose of change

It's a bit ridiculous that we can't use basic soap in washing machines, people used to use normal soap to wash clothes long before detergents were a thing.

Describe the solution

Some C++ work would be needed to allow washing machined to use them but i did add soap flakes and a recipe to make them to the JSON files.

Describe alternatives you've considered

Testing

The soap flakes item is in there but i can't test them in a washing machine yet.

this adds soap flakes which after come C# editing could be used in a washing machine
@anothersimulacrum
Copy link
Member

I will do the C++ work to make this function.

@Fris0uman
Copy link
Contributor

Could you change the title of the PR so that it actually give some info about the content?
Also it seems you have changed the whole files instead of just adding new recipe, passing it through the linter might fix it.

@yowshi
Copy link
Contributor Author

yowshi commented Nov 20, 2019

i did pass the code through the linter. when i was reading the guidelines about how you're supposed to format the JSON files i got worried so i did a copy and paste of the files into the linter and checked em.

also how do i change the PR?

@AMurkin
Copy link
Contributor

AMurkin commented Nov 20, 2019

PR was made from a not clean old branch. It may be easier to redo in the new branch after updating the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants