yowshi #35619
Closed
yowshi #35619
+2,616
−3,118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds soap flakes which after come C# editing could be used in a washing machine
|
I will do the C++ work to make this function. |
|
Could you change the title of the PR so that it actually give some info about the content? |
|
i did pass the code through the linter. when i was reading the guidelines about how you're supposed to format the JSON files i got worried so i did a copy and paste of the files into the linter and checked em. also how do i change the PR? |
|
PR was made from a not clean old branch. It may be easier to redo in the new branch after updating the master branch. |
I think this time i did the linting properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Added soap flakes recipe which could be used in a washing machine.
Purpose of change
It's a bit ridiculous that we can't use basic soap in washing machines, people used to use normal soap to wash clothes long before detergents were a thing.
Describe the solution
Some C++ work would be needed to allow washing machined to use them but i did add soap flakes and a recipe to make them to the JSON files.
Describe alternatives you've considered
Testing
The soap flakes item is in there but i can't test them in a washing machine yet.