Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heat and atmosphere in mi-go base #35618

Merged
merged 14 commits into from
Nov 26, 2019

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Nov 20, 2019

Summary

SUMMARY: Bugfixes "Adjusts the heat and toxic atmosphere of mi-go bases"

Purpose of change

Fixes #34914

It appears ZhilkinSerg finished jsonizing the heat field code only two weeks after the mi-go base went in, and I was on hiatus at the time and missed it. That's all that's been needed to fix this, so now I'm fixing it.

Describe the solution

Makes a tightly regulated temperature field, hot_air_sauna, that caps off in the high 60 degrees celsius but also has a high bottom end in the 50s - that's what was missing to the hot_air3 field before, it had the capacity to be much too cool. I'll have to test in summer to see how much the outside temperature affects things, but this should keep it uncomfortably hot year round without being completely fatal.

While I was in there, I also changed the concealing clouds of toxic gas in the base to the invisible, smothering atmosphere I'd intended. Instead of being poisonous it makes you tired and less combative. You're forced to choose between further overheating by wearing a gasmask, or being crippled by the toxic air.

Describe alternatives you've considered

I could leave it as is. Surprisingly, the blisteringly hot temperatures in the base didn't have as strong an impact on it as I'd thought: it's getting roughly the play reports I was aiming for, of being nearly impossible to brave, but not entirely. Still, the temperature is definitely not meant to be quite this high, and the fifties to sixties celsius should still be hot enough to seriously deter all but the most well prepared adventurers.

Testing

image
Temp is a bit low but works. The atmosphere effects don't go in stages as much as I'd like, I may tweak them later, but for now they're working well enough.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Nov 20, 2019
@I-am-Erk I-am-Erk changed the title Add new, appropriately adjusted, heat fields to mi-go base Update heat and atmosphere in mi-go base Nov 21, 2019
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/how-to-associate-an-effect-type-with-a-field-type/22018/2

@I-am-Erk I-am-Erk marked this pull request as ready for review November 23, 2019 04:31
@ZhilkinSerg ZhilkinSerg merged commit bd5ce83 into CleverRaven:master Nov 26, 2019
@I-am-Erk I-am-Erk deleted the mi-go_field_fixes branch November 26, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mi-go structures temperature too high for NPCs to live
3 participants