Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to filter by item notes #35617

Merged
merged 5 commits into from
Nov 25, 2019
Merged

Conversation

jagoly
Copy link
Contributor

@jagoly jagoly commented Nov 20, 2019

Summary

SUMMARY: Interface "Add 'n:' prefix for item filtering, to search through an items note."

Purpose of change

This is nice if we want to label a bunch of stuff for custom loot zones, but don't want to actually change the names of the items. It also means we can use whatever text we want, eg "n:kitchen" won't find kitchen units. Also possibly of use is just using n: or -n: alone, to filter items that do/don't have notes at all.

Describe alternatives you've considered

Just using labels like "kitchen_ chef knife", but that's a pain, and rather ugly.

Testing

Screenshot from 2019-11-20 16-23-02
Screenshot from 2019-11-20 16-25-48

Additional context

This could perhaps also work nicely with some method of mass-noting items. I might try to do that in another PR.

src/item_search.cpp Outdated Show resolved Hide resolved
src/item_search.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones labels Nov 22, 2019
@ZhilkinSerg ZhilkinSerg merged commit 8cc6f3d into CleverRaven:master Nov 25, 2019
@jagoly jagoly deleted the filterbynote branch April 6, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants