Replace hardcoded maths constants with named ones #35613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two places in the code using 1.41 now use M_SQRT2 instead. One comment using 3.14 now says 'pi'.
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
For code clarity and consistency.
Describe the solution
Two places in the code using
1.41now useM_SQRT2instead.One comment using
3.14now sayspi.Describe alternatives you've considered
One of these constants is changing from
floattodoubleas a result of this change, but I think the compiler should figure it out and be no slower.I considered writing
πinstead ofpi.Testing
Unit tests.