NPC Construction Fix #35604
Merged
NPC Construction Fix #35604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
<Bugfix>
|
with a fine assist from @ipcyborg the fix is gonna be improved in a minute. |
|
Sorry for the added commits, done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "NPC Construction Fix"Purpose of change
Fixes #35581 ( maybe )
Describe the solution
I introduced a bug where if the NPC needs to fetch components, the
get_zone_for_act()function didnt cover that activity type, and returned a null zone type id, which returned from the requirements check early as it didnt think the components were inside a zone.The solution is to check that the components are in ANY zone, and if so return the zone type that its already in.
Describe alternatives you've considered
N/A
Testing
Tested on my own save that had a similar bug, where they wouldtn finish a log wall, and now they can, but will ask the linked issue OP if it now resolves it.
Additional context
N/A