Only add a repair item once to the list of possible repair items. #35590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some (different) materials use the same repair item (iron and steel each use scrap metal). Repairing an item made of several of those materials would show a menu to the user for choosing which item to use for repairing. That menu had several identical entries (one for repairing iron with scrap metal, and one for repairing steel with scrap metal). That selection is unnecessary as both choices consume the same item. This commit detects that case and prevents the second entry from appearing.
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneSome (different) materials use the same repair item (iron and steel each use scrap metal). Repairing an item made of several of those materials would show a menu to the user for choosing which item to use for repairing. That menu had several identical entries (one for repairing iron with scrap metal, and one for repairing steel with scrap metal).
That selection is unnecessary as both choices consume the same item.
This commit detects that case and prevents the second entry from appearing.
Test for example with a damaged heavy duty frame.