Liter literal #35574
Merged
Liter literal #35574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had a _ml literal. Add a _liter literal. Replace all uses of _ml which were a whole number of liters with the new literal. This is the same number of characters, and easier to read (especially for the really big values; we have a few places with hundreds or thousands of liters being mentioned).
Remove the separate test files with time and energy tests. Consolidate them into one new file units_test.cpp, and add some tests for the other units-related stuff.
ZhilkinSerg
added
[C++]
ZhilkinSerg
added
the
Code: Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Some of our volume literals (like
10000000_ml) were hard to read.Describe the solution
Introduce a new user-defined literal suffix
_literfor thousands of ml. Use it in all the places it makes sense to.Also, rearrange and expand the units-related unit tests. We don't need a separate test file for each type of unit.
Testing
Ran the unit tests.