Fix spells sometimes missing despite successful cast #35568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missed_by was not initialized, leading to instances where sometimes spells would miss
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix spells sometimes missing despite successful cast"Purpose of change
Fixes #34633
Describe the solution
missed_bywas not initialized, leading to instances where sometimes spells would missDescribe alternatives you've considered
rewriting
monster::deal_projectile_attackTesting
Spawned a horde of zombie and used "Smite" on a bunch of them. All registered
Additional context
I have a feeling
monster::deal_projectile_attackis a tad obsolete