Clean up and update park.json #35541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
added
[JSON]
BevapDin
reviewed
Jan 2, 2020
| "place_items": [ | ||
| { "chance": 8, "item": "dogfight", "x": 2, "y": 12 }, | ||
| { "chance": 30, "item": "trash", "x": 6, "y": 10 }, | ||
| { "chance": 10, "item": "child_items", "x": 7, "y": 18 }, | ||
| { "chance": 3, "item": "creepy", "x": 22, "y": 21 }, | ||
| { "chance": 10, "item": "trash_forest", "x": 10, "y": 23 }, | ||
| { "chance": 20, "item": "trash_forest", "x": 18, "y": 22 }, | ||
| { "chance": 500, "item": "trash_forest", "x": 18, "y": 22 }, |
There was a problem hiding this comment.
Values that large are not valid here. Valid values are in the range 1 to 100.
There was a problem hiding this comment.
@I-am-Erk Should it be 50 (like in 50%) opposed to 500 (1 in 500)?
There was a problem hiding this comment.
Yes, that looks like an extra zero typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Clean up and modernize parks.json"Purpose of change
I wanted to add an overrun zombie killzone in a park, but the file was a mess so I had to fix that first.
Describe the solution
Removes outdated terms like f_null
Changes a lot of place_items and place_monsters to by letter designation
Reorganizes old ported maps that were sorted in alphabetical order instead of human-readable.
Adds variable terrain, eg. making random flower choices instead of placing dandelions and things all in the same place
Describe alternatives you've considered
I don't really have to do this, the maps work fine, but I can't not.
Testing
Tested, works fine. Parks aren't exactly like they were before but they're not too changed.
Additional context
Depending on how big this gets, I still might add an overrun fortification as part of this.